Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Foot Terminal #2592

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add Foot Terminal #2592

wants to merge 3 commits into from

Conversation

trn1ty
Copy link

@trn1ty trn1ty commented May 20, 2024

This is tested and works. Foot won't run in Xorg, only in the Wayland environment.

@Botspot
Copy link
Owner

Botspot commented May 20, 2024

Do you get this issue?
Fontsize too small to be readible.
20240520_11h08m55s_grim

@Botspot
Copy link
Owner

Botspot commented May 20, 2024

Output from running foot:

pi@raspberrypi:~ $ foot
info: main.c:421: version: 1.13.1 +pgo +ime +graphemes -assertions
info: main.c:428: arch: Linux aarch64/64-bit
info: main.c:440: locale: en_US.UTF-8
info: config.c:3003: loading configuration from /etc/xdg/foot/foot.ini
info: fcft.c:338: fcft: 3.1.5 +graphemes +runs +svg(nanosvg) -assertions
info: fcft.c:377: fontconfig: 2.14.1, freetype: 2.12.1, harfbuzz: 6.0.0, utf8proc: 2.8.0 (Unicode 15.0.0)
info: fcft.c:838: /usr/share/fonts/truetype/liberation2/LiberationMono-Regular.ttf: size=8.00pt/8px, dpi=75.00
info: wayland.c:1353: HDMI-A-1: 1920x1080+0x0@60Hz NCS HDMI      54.65" scale=1 PPI=40x41 (physical) PPI=40x41 (logical), DPI=40.31
info: wayland.c:1509: requesting SSD decorations
info: fcft.c:838: /usr/share/fonts/truetype/liberation2/LiberationMono-Bold.ttf: size=8.00pt/4px, dpi=40.31
info: fcft.c:838: /usr/share/fonts/truetype/liberation2/LiberationMono-Regular.ttf: size=8.00pt/4px, dpi=40.31
info: fcft.c:838: /usr/share/fonts/truetype/liberation2/LiberationMono-Italic.ttf: size=8.00pt/4px, dpi=40.31
info: fcft.c:838: /usr/share/fonts/truetype/liberation2/LiberationMono-BoldItalic.ttf: size=8.00pt/4px, dpi=40.31
info: terminal.c:700: cell width=2, height=6
info: terminal.c:588: using 4 rendering threads
info: wayland.c:859: using SSD decorations
info: wayland.c:1698: cursor theme: PiXflat, size: 24, scale: 1

@theofficialgman
Copy link
Collaborator

theofficialgman commented May 20, 2024 •
edited
Loading

your wayland compositor is reporting your connected HDMI device as a large 55 inch diagonal TV

info: wayland.c:1353: HDMI-A-1: 1920x1080+0x0@60Hz NCS HDMI      54.65" scale=1 PPI=40x41 (physical) PPI=40x41 (logical), DPI=40.31

default font size in the terminal is coded in source as monospace:size=8, it does not read the system default font size or font.

based on your debug logs and the picture, it does appear that the font (8) is displaying correctly in foot for its default settings. as a reminder, font size is a representation of the physical size of the font.
more info here https://codeberg.org/dnkl/foot#dpi-and-font-size

@theofficialgman theofficialgman marked this pull request as draft May 20, 2024 20:19
@theofficialgman
Copy link
Collaborator

This is tested and works. Foot won't run in Xorg, only in the Wayland environment.

I feel like additional checks will need to be added for that limitation in order to add to terminal-run. we don't want users to be unable to run the terminal because they switched to an xorg session and have foot as their default x-terminal-emulator if they have other terminals that could run.

@theofficialgman theofficialgman added Upstream Bug something isn't working that can only be fixed upstream changes requested labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes requested Upstream Bug something isn't working that can only be fixed upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trn1ty @Botspot @theofficialgman